Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unmarshal IntegerOption #421

Merged
merged 2 commits into from
Mar 6, 2024
Merged

fix unmarshal IntegerOption #421

merged 2 commits into from
Mar 6, 2024

Conversation

yakuroot
Copy link
Contributor

@yakuroot yakuroot commented Mar 6, 2024

The update of #372 was not made, so I wrote the code myself.

Use a switch instead of a map to verify the type.

diamondburned
diamondburned previously approved these changes Mar 6, 2024
View reviewed changes
@diamondburned
Copy link
Owner

Could you fix the failing test(s)?

@yakuroot
Copy link
Contributor Author

yakuroot commented Mar 6, 2024

I fixed the failing test, could you please check again?

@diamondburned diamondburned merged commit 5089b62 into diamondburned:v3 Mar 6, 2024
5 checks passed
@diamondburned diamondburned mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diamondburned diamondburned diamondburned approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yakuroot @diamondburned